Shhhht! The crew is at work 🤫

Discover the baksla.sh team members while they're working

💡 Click on a member to discover their full profile.

@@ -10,7 +10,7 @@

use App\Team\Infrastructure\Repository\InMemoryMemberRepository;

use Symfony\Component\HttpFoundation\Exception\NotFoundHttpException;

use Symfony\Component\HttpFoundation\Request;

use Symfony\Component\HttpFoundation\Response;

use Symfony\Component\HttpKernel\Attribute\AsController;

use Symfony\Component\Routing\Attribute\Route;

use Twig\Environment;

Could we alias this import to Twig to make it a little more understandable?

What about extending AbstractController and use the render() method?

#[AsController]

final readonly class ViewTeam

{

public function __construct(

private Environment $twig,

private InMemoryMemberRepository $memberRepository,

This should depend on an interface instead to avoid coupling to implementation details

👍 That Repository contract belongs to the Domain layer IMHO.

To target a specific implementation, you can use the Autowire attribute.

) {

}

#[Route(name: 'app_team', path: '/team')]

public function __invoke(Request $request): Response

{

return new Response();

if ('GET' !== $request->getMethod()) {

throw new NotFoundHttpException();

While it works, #[Route(methods: ['GET'])] is a better way to achieve this.

Indeed, better leverage Symfony Routing capabilities so you can focus on the business logic.

}

return new Response($this->twig->render('pages/team/index.html.twig', [

'members' => $this->memberRepository->findAll(),

Should it return a paginated result instead?

AFAIK, baksla.sh isn't gonna have enough members to need pagination anytime soon 😉

]);

Extra blank line 👀

}

Reviewers (9)