Shhhht!
The crew is at work.

Pro tip

Tap any reviewer for their bio and socials.

Open mtarld wants to merge 1 commit into main from team/view-team-page

feat: ship the /team page with the in-memory roster

src/Team/Infrastructure/Controller/ViewTeam.php …/Controller/ViewTeam.php 12 1

…/Controller/ViewTeam.php src/Team/Infrastructure/Controller/ViewTeam.php

@@ -10,7 +10,7 @@ final readonly class ViewTeam

added: use App\Team\Infrastructure\Repository\InMemoryMemberRepository;

use Symfony\Component\HttpFoundation\Exception\NotFoundHttpException;

use Symfony\Component\HttpFoundation\Request;

use Symfony\Component\HttpFoundation\Response;

use Symfony\Component\HttpKernel\Attribute\AsController;

use Symfony\Component\Routing\Attribute\Route;

added: use Twig\Environment;

Thread · 2 comments

Could we alias this import to Twig to make it a little more understandable?

What about extending AbstractController and use the render() method?

#[AsController]

final readonly class ViewTeam

    public function __construct(

added:         private Environment $twig,

added:         private InMemoryMemberRepository $memberRepository,

Thread · 3 comments

This should depend on an interface instead to avoid coupling to implementation details

👍 That Repository ((opens in a new tab)) contract belongs to the Domain layer IMHO.

To target a specific implementation, you can use the Autowire attribute ((opens in a new tab)).

) {

    #[Route(name: 'app_team', path: '/team')]

    public function __invoke(Request $request): Response

removed:         return new Response();

added:         if ('GET' !== $request->getMethod()) {

added:             throw new NotFoundHttpException();

Thread · 2 comments

While it works, #[Route(methods: ['GET'])] is a better way to achieve this.

Indeed, better leverage Symfony Routing capabilities so you can focus on the business logic.

added:         }

added:

added:         return new Response($this->twig->render('pages/team/index.html.twig', [

added:             'members' => $this->memberRepository->findAll(),

Thread · 2 comments

Should it return a paginated result instead?

AFAIK, baksla.sh isn't gonna have enough members to need pagination anytime soon 😉

added:         ]));

added:

Thread · 1 comment

Extra blank line 👀